Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Buildroot #329

Merged
merged 2 commits into from
Mar 26, 2022
Merged

Add Buildroot #329

merged 2 commits into from
Mar 26, 2022

Conversation

jolivain
Copy link
Contributor

@jolivain jolivain commented Mar 9, 2022

This pull request adds Buildroot Linux in distro.id() documentation list and a test.
See: https://buildroot.org/

For Buildroot information, see https://buildroot.org/

Buildroot systems follows the freedesktop.org /etc/os-release spec. See:
https://git.busybox.net/buildroot/commit/?id=451a887894faddef019e9a0628c21b5f2e9eee56

Signed-off-by: Julien Olivain <ju.o@free.fr>
Add a test for Linux systems generated with Buildroot:
https://buildroot.org/

Buildroot systems follows the freedesktop.org /etc/os-release spec. See:
https://git.busybox.net/buildroot/commit/?id=451a887894faddef019e9a0628c21b5f2e9eee56

Example of `distro -j` output:

    {
        "codename": "",
        "id": "buildroot",
        "like": "",
        "version": "2022.02",
        "version_parts": {
            "build_number": "",
            "major": "2022",
            "minor": "02"
        }
    }

Signed-off-by: Julien Olivain <ju.o@free.fr>
@HorlogeSkynet
Copy link
Member

( @jolivain Very very picky hat taken from @hartwork : from this commit you included in the second commit, do we want to "officially" support Buildroot versions older than 2012-02 too ? 🧐 )
((internally, _DISTRO_RELEASE_BASENAME_PATTERN regexp matches br-version file name !))

@hartwork
Copy link
Contributor

Very very picky hat taken from @hartwork

@HorlogeSkynet 😃 I think I started using phrase "with my picky hat on" because of Edward de Bono's Six Thinking Hats. I may also have seen it verbatim somewhere else. Greetings 🍻

@jolivain
Copy link
Contributor Author

( @jolivain Very very picky hat taken from @hartwork : from this commit you included in the second commit, do we want to "officially" support Buildroot versions older than 2012-02 too ? monocle_face ) ((internally, _DISTRO_RELEASE_BASENAME_PATTERN regexp matches br-version file name !))

Hi @HorlogeSkynet,

No, I don't expect distro to officially support Buildroot older than 2012.02.

python-distro was introduced in commit:
https://git.busybox.net/buildroot/commit/?id=d01f3401320077c6d572135e47ffc4ae218a6ef5
which is included tag 2022.02.

According to https://nightly.buildroot.org/manual.html#_releases
LTS releases are maintained for one year.

Buildroot is not really meant to install packages at runtime, which is why I'm not expecting any support for older releases anyway.

Do you want me to create a new commit adding br-version in _DISTRO_RELEASE_IGNORE_BASENAMES ?

Best regards,

Julien.

@HorlogeSkynet
Copy link
Member

Thanks for your detailed response @jolivain. Thus, I guess we're good this way. Let's merge this 👍

@HorlogeSkynet HorlogeSkynet changed the title Add buildroot Add Buildroot Mar 26, 2022
@HorlogeSkynet HorlogeSkynet merged commit b64ce77 into python-distro:master Mar 26, 2022
HorlogeSkynet pushed a commit that referenced this pull request Jun 7, 2022
HorlogeSkynet pushed a commit that referenced this pull request Jun 21, 2022
@hartwork hartwork added this to the 1.8.0 milestone Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants